Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

No description provided.

The Dumper no longer has anything to do specifically with JSON, it
merely represents processing into an `Analysis` output.
@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2019
@Xanewok
Copy link
Member

Xanewok commented Jul 26, 2019

Looks good, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 26, 2019

📌 Commit 68c0ba2 has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 27, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
Centril added a commit to Centril/rust that referenced this pull request Jul 27, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
bors added a commit that referenced this pull request Jul 27, 2019
Rollup of 6 pull requests

Successful merges:

 - #62423 (Fix cycle error with existential types)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #62982 (Don't access a static just for its size and alignment)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)
 - #63036 (Add lib section to rustc_lexer's Cargo.toml)

Failed merges:

r? @ghost
@bors bors merged commit 68c0ba2 into rust-lang:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants